feat: add encumber aggregate utxo creation method for wallet cli #4798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an m-of-n multisig TariScript that returns the aggregate public key of the signatories if successful and fails otherwise.
…gregatePubKey' into ja-multisig-signature-utxo
Description --- Removed stray unwrap in liveness service Motivation and Context --- Caused a base node to panic in stress test conditions. ``` thread 'tokio-runtime-worker' panicked at 'called `Result::unwrap()` on an `Err` value: DhtOutboundError(RequesterReplyChannelClosed)', base_layer\p2p\src\services\liveness\service.rs:164:71 ``` How Has This Been Tested? --- Tests pass
jorgeantonio21
changed the title
SWvheerden
reviewed
Oct 12, 2022
base_layer/core/src/transactions/transaction_components/unblinded_output.rs
Outdated
Show resolved
Hide resolved
base_layer/core/src/transactions/transaction_components/unblinded_output.rs
Show resolved
Hide resolved
base_layer/core/src/transactions/transaction_protocol/transaction_initializer.rs
Outdated
Show resolved
Hide resolved
Comment on lines
1159
to
1160
| let _size = self | ||
| .event_publisher | ||
| .send(Arc::new(TransactionEvent::TransactionCompletedImmediately(tx_id))); |
There was a problem hiding this comment.
We dont want to complete this yet, remember this is incomplete
Comment on lines
1170
to
1194
| self.output_manager_service | ||
| .add_rewindable_output_with_tx_id( | ||
| tx_id, | ||
| unblinded_output, | ||
| Some(SpendingPriority::Normal), | ||
| Some(rewind_data), | ||
| ) | ||
| .await?; | ||
| self.submit_transaction( | ||
| transaction_broadcast_join_handles, | ||
| CompletedTransaction::new( | ||
| tx_id, | ||
| self.resources.node_identity.public_key().clone(), | ||
| self.resources.node_identity.public_key().clone(), | ||
| amount, | ||
| fee, | ||
| tx.clone(), | ||
| TransactionStatus::Completed, | ||
| "".to_string(), | ||
| Utc::now().naive_utc(), | ||
| TransactionDirection::Outbound, | ||
| None, | ||
| None, | ||
| None, | ||
| ), | ||
| )?; |
There was a problem hiding this comment.
We dont want to complete this yet, remember this is incomplete
leave this as pending
jorgeantonio21
force-pushed
the
ja-multisig-metadata-signature-utxo
branch
from
30a589c
to
a79e644
Compare
stringhandler
approved these changes
Oct 13, 2022
hansieodendaal
added a commit
to hansieodendaal/tari
that referenced
this pull request
Jun 24, 2024
hansieodendaal
added a commit
to hansieodendaal/tari
that referenced
this pull request
Jun 24, 2024
hansieodendaal
added a commit
to hansieodendaal/tari
that referenced
this pull request
Jun 24, 2024
4 tasks
hansieodendaal
added a commit
to hansieodendaal/tari
that referenced
this pull request
Jun 24, 2024
hansieodendaal
added a commit
to hansieodendaal/tari
that referenced
this pull request
Jun 24, 2024
hansieodendaal
added a commit
to hansieodendaal/tari
that referenced
this pull request
Jun 26, 2024
hansieodendaal
added a commit
to hansieodendaal/tari
that referenced
this pull request
Jun 27, 2024
SWvheerden
pushed a commit
that referenced
this pull request
Jun 28, 2024
Description --- Apply m_of_n_feature branch - PR #4751 - PRs #4759, #4776, #4798, #4822 Motivation and Context --- Add m-of-n scripting ability How Has This Been Tested? --- **Note:** Not tested yet What process can a PR reviewer use to test or verify this change? --- Code review <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Given a list of signatures, and other metadata, it is desirable to create an encumber aggregate utxo. This PR attempts to produce logic for this new feature.
Motivation and Context
How Has This Been Tested?