feat(tariscript): adds ToRistrettoPoint op-code #4749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delta1
reviewed
Sep 28, 2022
| @@ -116,6 +116,7 @@ pub const OP_CHECK_MULTI_SIG_VERIFY: u8 = 0xaf; | |||
| pub const OP_HASH_BLAKE256: u8 = 0xb0; | |||
| pub const OP_HASH_SHA256: u8 = 0xb1; | |||
| pub const OP_HASH_SHA3: u8 = 0xb2; | |||
| pub const OP_TO_RISTRETTO_POINT: u8 = 0xb3; | |||
There was a problem hiding this comment.
sdbondi
force-pushed
the
tariscript-add-to-ristretto-point
branch
from
5c1c0f8
to
432446d
Compare
hansieodendaal
previously approved these changes
Sep 28, 2022
willyrgf
reviewed
Sep 29, 2022
|
What do you think about this kind of approach to |
Yeah that is a little nicer, however I'd favour the current approach over introducing another dependency. |
sdbondi
force-pushed
the
tariscript-add-to-ristretto-point
branch
from
dcb5287
to
cd56a4f
Compare
Yes, it's make sense. Maybe in the future with |
stringhandler
approved these changes
Oct 3, 2022
|
In future we will need to hard fork these in, but since this will not be used immediately, there should be enough time for nodes to upgrade |
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Oct 3, 2022
* development: v0.38.5 feat: different default grpc ports for different networks (tari-project#4755) fix(core): broken doctests (tari-project#4763) ci: fix coverage job ci: run coverage on prs (tari-project#4738) fix(comms): fixes edge case where online status event does not get published (tari-project#4756) fix(dht/encryption): greatly reduce heap allocations for encrypted messaging (tari-project#4753) docs: explain the emission curve parameters (tari-project#4750) fix(comms/peer_manager): add migration to remove onionv2 addresses (tari-project#4748) fix(ci): add cargo cache, reduce Ubuntu dependencies and action on pull_request (tari-project#4757) feat(tariscript): adds ToRistrettoPoint op-code (tari-project#4749) fix: cli wallet cucumber (tari-project#4739) fix(clients): fix tari nodejs client proto paths (tari-project#4743) chore: disallow onion v2 (tari-project#4745) feat: change priority in mempool to take into account age (tari-project#4737) feat: trigger mempool sync on lag (tari-project#4730) fix(core): use compact inputs for block propagation (tari-project#4714) ci: deny dbg macro (tari-project#4740)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
As per RFC-202
Ref tari-project/rfcs#15
Ref #4742
How Has This Been Tested?
Additional unit tests + tests updated