refactor: split up app grpc proto files #4466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
apps-grpc-split-up
branch
from
1e8a57a to
4613652
Compare
|
|
sdbondi
force-pushed
the
apps-grpc-split-up
branch
from
4613652 to
a5f6727
Compare
stringhandler
approved these changes
Aug 18, 2022
stringhandler
pushed a commit
that referenced
this pull request
Aug 29, 2022
Description --- - adds CodeTemplateRegistration output type - adds TemplateRegistration to SideChainFeatures - add grpc methods for registering a code template Motivation and Context --- Code templates need to be committed to on L1. The `binary_url` and `repo_url` fields are not validated by base node consensus because: 1. The rust implementation of Multiaddr does not currently support paths in http addresses e.g. `/dns4/github.com/tcp/443/http/tari-project/tari.git` is not well-formed however [the spec](https://multiformats.io/multiaddr/) says it should be. 2. Url parsing is complex and adding it to consensus code could introduce bugs (general/security/DoS) Depends on #4466 Depends on #4496 How Has This Been Tested? --- TODO: add cucumber tests for this output type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Splits up
types.protointotransaction.proto,block.protoandsidechain_types.protoMotivation and Context
types.protohad many somewhat unrelated types that could be better split up which makes them more maintainable.It also makes it clear what types each protobuf service interface requires.
How Has This Been Tested?
Code compiles and tests pass