Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add checkpoint_number to checkpoint with basic base layer validations #4258

Merged

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Jul 1, 2022

Description

  • feat(validator-node): specify checkpoint number in create checkpoint request
  • feat(base_layer/wallet): adds checkpoint_number to asset manager
  • feat(base_layer/core): adds checkpoint number validation
  • feat(base_layer/wallet): adds checkpoint number to proto files
  • feat(base_layer/core): adds checkpoint_number to checkpoint

Motivation and Context

A checkpoint number provides a sequential ordering of checkpoints that is validated by the base layer.
This should make dan layer coordination of checkpointing easier and provides an indication of how much checkpoint history has existed on chain.

How Has This Been Tested?

New unit tests for the base layer validations
Manually (In progress)

@aviator-app aviator-app bot merged commit 7b76141 into tari-project:development Jul 1, 2022
@sdbondi sdbondi deleted the core-checkpoint-number branch July 1, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants