feat: swap dalek bulletproofs for bulletproofs-plus #4213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansieodendaal
force-pushed
the
ho_bulletproofs_plus
branch
7 times, most recently
from
dc10c2d
to
1f1d425
Compare
hansieodendaal
changed the title
hansieodendaal
force-pushed
the
ho_bulletproofs_plus
branch
2 times, most recently
from
25bca9c
to
8895b3c
Compare
base_layer/core/src/transactions/transaction_components/test.rs
Outdated
Show resolved
Hide resolved
Swapped out Dalek Bulletproofs for Tari Bulletproofs+ using the most basic range proof creation and verification update to references + igor genesis block
| @@ -610,27 +607,14 @@ impl OutputManagerHandle { | |||
| } | |||
| } | |||
|
|
|||
| pub async fn get_outputs_by(&mut self, q: OutputBackendQuery) -> Result<Vec<UnblindedOutput>, OutputManagerError> { | |||
There was a problem hiding this comment.
This seems to be a bad merge
There was a problem hiding this comment.
O, that was a piece of unused code that I cleaned up.
| let mut rewound_outputs: Vec<(UnblindedOutput, BulletRangeProof)> = Vec::new(); | ||
| for output in outputs { | ||
| // TODO: Only outputs with scripts `== script!(Nop)` is recover-able - can this be improved? | ||
| if output.script != script!(Nop) { |
There was a problem hiding this comment.
Is this really the case?
There was a problem hiding this comment.
The previous version of the code had this exact check - if a rewound was successful but the script was not script!(Nop) it dropped the output. Maybe this is latent defect? That is why I logged a TODO, but I will also register an issue.
hansieodendaal
force-pushed
the
ho_bulletproofs_plus
branch
from
8895b3c
to
4e3f1c5
Compare
stringhandler
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Swapped out Dalek Bulletproofs for Tari Bulletproofs+ using the most basic range proof creation and verification
Motivation and Context
How Has This Been Tested?