fix: fix Tor ID deserialization issue #3950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to an issue with excluding the private key from the TorIdentity serialization that was fixed in tari-project#3946 any console wallets that ran the old code would crash on startup with a serialization error. This PR adds some resilience to the startup process that if it cannot deserialize the old Tor Id it will log the issue and then use a newly generated one.
aviator-app bot
pushed a commit
that referenced
this pull request
Mar 23, 2022
Description --- - adds code to store the identity signature Motivation and Context --- Whenever the node address changes, the identity signature is resigned for the new address. This identity signature should be preserved and reloaded later. Ref #3950 How Has This Been Tested? --- Manually: Checking that identity signature is stored and doesnt change between reboots
sdbondi
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to an issue with excluding the private key from the TorIdentity serialization that was fixed in #3946 any console wallets that ran the old code would crash on startup with a serialization error.
This PR adds some resilience to the startup process that if it cannot deserialize the old Tor Id it will log the issue and then use a newly generated one.
How Has This Been Tested?
Manually