feat(wallet): add grpc method for setting base node

[zhangcheng]

Description

Aim to resolve #3821

Motivation and Context

Learning via "good first issue"

How Has This Been Tested?

Code compiles, and manual test with grpcurl.

[delta1]

Thanks @zhangcheng looks good! You will just have to run cargo fmt --all to pass clippy CI.

Regarding testing:

• manually: use a gRPC client to to call against your method with the wallet running
• automated: take a look at integration_tests folder (but you can leave this out for now)

[zhangcheng]

Got it, thx @delta1 , will clippy it.

[philipr-za]

Looks good, will approve once Clippy passes.

[zhangcheng]

I tried to use grpcurl to test against it, but my limited knowledge couldn't help me to construct valid inputs.
It'd be very helpful if there is a brief guide or alike to educate newbies like me on how to properly construct needed inputs with the correct format.

grpcurl -plaintext \
    -import-path ./applications/tari_app_grpc/proto \
    -proto wallet.proto \
    -d '{"public_key": "36a9df45e1423b5315ffa7a91521924210c8e1d1537ad0968450f20f21e5200d", "net_address": "localhost"}' \
    localhost:18143 \
    tari.rpc.Wallet.SetBaseNode

[philipr-za]

I tried to use grpcurl to test against it, but my limited knowledge couldn't help me to construct valid inputs. It'd be very helpful if there is a brief guide or alike to educate newbies like me on how to properly construct needed inputs with the correct format.

grpcurl -plaintext \
    -import-path ./applications/tari_app_grpc/proto \
    -proto wallet.proto \
    -d '{"public_key": "36a9df45e1423b5315ffa7a91521924210c8e1d1537ad0968450f20f21e5200d", "net_address": "localhost"}' \
    localhost:18143 \
    tari.rpc.Wallet.SetBaseNode

I haven't personally tested a CLI gRPC client at all, I prefer a GUI client like BloomRPC which can just ingest the proto file. from a glance that request looks ok except for the format of the net_address field. We are using the self describing MultiAddr which would look like /ip4/127.0.0.1.

[delta1]

I agree with @philipr-za it's much easier to test with a GUI. But not a showstopper here, if the CI passes then LGTM

[stringhandler]

The address can be /ip4/127.0.0.1/tcp/18142

[stringhandler]

Just need to sign your commits

[zhangcheng]

ERROR:
Code: InvalidArgument
Message: Base node public key was not a valid pub key: The input data was the incorrect length to perform the desired conversion

Since I don't know how to construct a valid public key string for this case yet, the above string was pulled out of the log files, such as:

2022-02-14 12:00:06.557504000 [comms::node] [Thread:4469540224] INFO Your node's public key is '1ed8d6e659bdabc5bd1f7cb6f8cfbbdbd97f5413fb8c40fc35fcc4cccb54df69'

[stringhandler]

The grpc client often wants bytes to be base64, so you can try HtjW5lm9q8W9H3y2+M+729l/VBP7jED8NfzEzMtU32k=

[zhangcheng]

Just need to sign your commits

Something new for me to learn then. 😄

[zhangcheng]

Cool, base64 string works. Thanks @mikethetike 🤝

grpcurl -plaintext \
    -import-path ./applications/tari_app_grpc/proto \
    -proto wallet.proto \
    -d '{"public_key": "HtjW5lm9q8W9H3y2+M+729l/VBP7jED8NfzEzMtU32k=", "net_address": "/ip4/127.0.0.1/tcp/18142"}' \
    localhost:18143 \
    tari.rpc.Wallet.SetBaseNode

Console output:

Tari Console Wallet running... (gRPC mode started)
Setting base node peer...
1ed8d6e659bdabc5bd1f7cb6f8cfbbdbd97f5413fb8c40fc35fcc4cccb54df69::/ip4/127.0.0.1/tcp/18142

[delta1]

Well done 👏

[delta1]

@zhangcheng https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

[zhangcheng]

I haven't personally tested a CLI gRPC client at all, I prefer a GUI client like BloomRPC which can just ingest the proto file.

Just want to say, BloomRPC is much nicer and easier to use than grpcurl, esp. to a newbie. @philipr-za

[stringhandler]

I preferred the binary version, but this is fine too.

[stringhandler]

I've queued it. If the CI passes, it will get merged. Thanks so much!