Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent key leaking through derive debug impl #3735

Merged
merged 2 commits into from
Jan 24, 2022
Merged

fix: prevent key leaking through derive debug impl #3735

merged 2 commits into from
Jan 24, 2022

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Jan 24, 2022

Description

  • Impl custom Debug for UnblindedOutput to prevent inadvertent leaking of private keys

Motivation and Context

Secret keys would previously have been written to logs if debug formatting was used

How Has This Been Tested?

stringhandler
stringhandler approved these changes Jan 24, 2022
View reviewed changes
Copy link
Collaborator

@stringhandler stringhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@aviator-app aviator-app bot merged commit 12a90e6 into tari-project:development Jan 24, 2022
@sdbondi sdbondi deleted the core-unblinded-transactions-security branch January 24, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stringhandler stringhandler stringhandler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdbondi @stringhandler