Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: reinstate 2 min blocks for dibbler #3720

Merged
merged 3 commits into from
Jan 20, 2022
Merged

chore!: reinstate 2 min blocks for dibbler #3720

merged 3 commits into from
Jan 20, 2022

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Jan 20, 2022

Description

  • Updates dibble consensus to 2-minute blocks
  • Updates dibbler genesis timestamp

Motivation and Context

Dibbler block times are too fast

How Has This Been Tested?

@sdbondi sdbondi force-pushed the core-genesis-2-minute-block-tiem branch from 16db216 to a8e368b Compare January 20, 2022 07:50
@delta1
Copy link
Contributor

delta1 commented Jan 20, 2022

Previous weatherwax constants

image

@sdbondi sdbondi force-pushed the core-genesis-2-minute-block-tiem branch from 0745637 to a0c9207 Compare January 20, 2022 08:06
@sdbondi
Copy link
Member Author

sdbondi commented Jan 20, 2022

@delta1 Ah you're right - thanks

delta1
delta1 reviewed Jan 20, 2022
View reviewed changes
Copy link
Contributor

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just the max_target_time from weatherwax

base_layer/core/src/consensus/consensus_constants.rs Outdated Show resolved Hide resolved
@aviator-app aviator-app bot merged commit 3c5890d into tari-project:development Jan 20, 2022
@sdbondi sdbondi deleted the core-genesis-2-minute-block-tiem branch January 20, 2022 08:58
@sdbondi sdbondi restored the core-genesis-2-minute-block-tiem branch February 3, 2022 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delta1 delta1 delta1 left review comments

@stringhandler stringhandler stringhandler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdbondi @delta1 @stringhandler