fix(comms): improve simultaneous connection handling #3697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
comms-improve-simultaneous-connections
branch
3 times, most recently
from
d8522d5
to
154086e
Compare
sdbondi
force-pushed
the
comms-improve-simultaneous-connections
branch
from
154086e
to
c564a9a
Compare
stringhandler
approved these changes
Jan 12, 2022
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jan 12, 2022
* development: fix(comms): improve simultaneous connection handling (tari-project#3697) refactor(mempool)!: optimisations,excess sig index,fix weight calc (tari-project#3691)
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jan 12, 2022
* development: fix(comms): improve simultaneous connection handling (tari-project#3697) refactor(mempool)!: optimisations,excess sig index,fix weight calc (tari-project#3691)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Observed a case where two nodes simultaneously dial and end up with no connections to each other due to a mis-timed peer disconnected event. The connection would have to wait for DHT connectivity to eventually redial to recover. Inactivity timeouts for messaging were a patch for the outbound messaging staying open, but this is not properly detected and handled.
How Has This Been Tested?
Existing tests updated
Manually: two base nodes that previously "lost" their connection due to this bug