-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: covenants implementation #3656
Merged
aviator-app
merged 12 commits into
tari-project:development
from
sdbondi:core-covenants-initial-impl
Jan 11, 2022
Merged
feat: covenants implementation #3656
aviator-app
merged 12 commits into
tari-project:development
from
sdbondi:core-covenants-initial-impl
Jan 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
core-covenants-initial-impl
branch
2 times, most recently
from
December 13, 2021 14:32
d9ab86f
to
cf0a720
Compare
sdbondi
changed the title
feat: mimblewimble covenants implementation
feat: covenants implementation
Dec 13, 2021
sdbondi
force-pushed
the
core-covenants-initial-impl
branch
from
December 16, 2021 07:21
483405a
to
7fcffb4
Compare
sdbondi
force-pushed
the
core-covenants-initial-impl
branch
from
December 16, 2021 07:21
7fcffb4
to
19278f1
Compare
sdbondi
force-pushed
the
core-covenants-initial-impl
branch
from
January 4, 2022 07:15
83c2279
to
35fe579
Compare
delta1
reviewed
Jan 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice looks really great, just one possible off-by-1 in the range otherwise LGTM
delta1
previously approved these changes
Jan 6, 2022
🖇 |
* development: feat: dibbler new genesis block with faucet utxos (tari-project#3688) ci: fix clippy warning on generated proto module (tari-project#3690) test: fix metadata signature cucumber (tari-project#3687) refactor!: clean up #testnet reset TODOs (tari-project#3682) feat(comms)!: add signature to peer identity to allow third party identity updates (tari-project#3629) chore: remove moving lock.mdb (tari-project#3674) chore: merge weatherwax v0.22.1.1 v0.22.1 ci: add build step (tari-project#3678) fix: edge cases causing bans during header/block sync (tari-project#3661) fix: end stale outbound queue immediately on disconnect, retry outbound messages (tari-project#3664) feat: add search by commitment to explorer (tari-project#3668) feat: tari launchpad (tari-project#3671) feat: base_node switching for console_wallet when status is offline (tari-project#3639) feat: improve wallet recovery and scanning handling of reorgs (tari-project#3655) feat: add GRPC call to search for utxo via commitment hex (tari-project#3666) feat: custom_base_node in config (tari-project#3651) fix: return correct index for include_pruned_utxos = false (tari-project#3663)
stringhandler
approved these changes
Jan 11, 2022
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jan 11, 2022
* development: feat: covenants implementation (tari-project#3656) ci: add tor script to binaries bundle (tari-project#3689)
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jan 11, 2022
* development: (28 commits) feat: covenants implementation (tari-project#3656) ci: add tor script to binaries bundle (tari-project#3689) chore: remove testnet reset todo in wallet (tari-project#3685) feat: dibbler new genesis block with faucet utxos (tari-project#3688) ci: fix clippy warning on generated proto module (tari-project#3690) test: fix metadata signature cucumber (tari-project#3687) refactor!: clean up #testnet reset TODOs (tari-project#3682) feat(comms)!: add signature to peer identity to allow third party identity updates (tari-project#3629) chore: remove moving lock.mdb (tari-project#3674) chore: merge weatherwax feat!: provide a compact form of TransactionInput (tari-project#3460) fix: allow 0-conf in blockchain db (tari-project#3680) v0.22.1.1 v0.22.1 ci: add build step (tari-project#3678) test: fix cucumber WalletQuery.feature (tari-project#3677) test: fix `wait for` step (tari-project#3673) fix: edge cases causing bans during header/block sync (tari-project#3661) perf(comms)!: optimise connection establishment (tari-project#3658) fix: end stale outbound queue immediately on disconnect, retry outbound messages (tari-project#3664) ...
aviator-app bot
pushed a commit
that referenced
this pull request
Jan 13, 2022
## Description - add covenants to txos - validate covenants for transactions and blocks ## Motivation and Context Based on #3656 ## How Has This Been Tested? New unit test Manually on dibbler, mined a few blocks and a sent transaction (empty covenant)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Adding Covenants to inputs/outputs structs and validation is left for another PR - this is not a breaking change.
How Has This Been Tested?
Many new unit tests