Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add tcp bypass settings for tor in wallet_ffi #3615

Merged

Conversation

StriderDM
Copy link
Contributor

Description

This PR allows the TCP bypass settings for Tor to be set via wallet_ffi instead of being hard-coded.

Motivation and Context

As above.

How Has This Been Tested?

cargo test --all
nvm use 12.22.6 && node_modules/.bin/cucumber-js --profile "ci" --tags "not @long-running and not @broken and @wallet-ffi"

@StriderDM StriderDM force-pushed the wallet_ffi_tcp_bypass_settings branch from aaa6429 to 538d614 Compare November 24, 2021 12:57
@StriderDM StriderDM changed the title feat!: add tcp bypass for tor in wallet_ffi feat!: add tcp bypass settings for tor in wallet_ffi Nov 24, 2021
sdbondi
sdbondi previously approved these changes Nov 25, 2021
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - though I perhaps wouldn't have exposed tor_proxy_bypass_address without a use case for it.

base_layer/wallet_ffi/src/lib.rs Outdated Show resolved Hide resolved
Review comments

Update proxy_opts.rs
@StriderDM StriderDM force-pushed the wallet_ffi_tcp_bypass_settings branch from aa8da87 to 991b93f Compare November 25, 2021 08:46
@aviator-app aviator-app bot merged commit 1003f91 into tari-project:development Nov 26, 2021
sdbondi added a commit to sdbondi/tari that referenced this pull request Dec 6, 2021
* development: (29 commits)
  fix(pruned mode)!: prune inputs, allow horizon sync resume and other fixes (tari-project#3521)
  feat!: sending one-sided transactions in wallet_ffi (tari-project#3634)
  fix: use json 5 for tor identity (regression) (tari-project#3624)
  test: add operation_id to log messages (tari-project#3633)
  fix!: multiple monerod addresses in tari merge mining proxy (tari-project#3628)
  fix: get-peer command works with public key again (tari-project#3636)
  fix!: separate peer seeds to common.network (tari-project#3635)
  test: removed stress test log target (tari-project#3631)
  feat: removed transaction validation redundant events (tari-project#3630)
  feat: improve wallet responsiveness (tari-project#3625)
  feat: add bulletproof rewind profiling (tari-project#3618)
  fix!: console wallet grpc_console_wallet_addresss config (tari-project#3619)
  test: increase timeout in cucumber (tari-project#3621)
  chore: change status line (tari-project#3610)
  feat!: add tcp bypass settings for tor in wallet_ffi (tari-project#3615)
  feat: only trigger UTXO scanning when a new block event is received (tari-project#3620)
  feat: implement dht pooled db connection (tari-project#3596)
  feat: add page for detailed mempool in explorer (tari-project#3613)
  chore: add pub key in the dailes notify (tari-project#3612)
  feat: display network for console wallet (tari-project#3611)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants