-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement prometheus metrics for base node #3563
feat: implement prometheus metrics for base node #3563
Conversation
4ab09cb
to
6597385
Compare
Looks good will try it out. Random test failure that might have been fixed on dev? |
f73577e
to
0a5c635
Compare
0a5c635
to
9deaedd
Compare
20f4c11
to
b3a3b86
Compare
This comment has been minimized.
This comment has been minimized.
0ce8ece
to
6339434
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I'm personally not a big fan of having many different compile time features, because you then have to create a matrix of possibilities to compile and test against. But that said, I see why you did it here, and I might have done the same.
Happy for it to go in
* development: feat: implement multiple read single write for sqlite (tari-project#3568)
* development: (32 commits) feat: add atomic swap refund transaction handling (tari-project#3573) feat: improve wallet connectivity status for console wallet (tari-project#3577) v0.21.1 feat: add error codes to LibWallet for CipherSeed errors (tari-project#3578) ci: split cucumber job into two (tari-project#3583) feat(wallet): import utxo’s as EncumberedToBeReceived rather than Unspent (tari-project#3575) docs: rfc 0250_Covenants (tari-project#3574) feat: get fee for transactions for stratum transcoder (tari-project#3571) test: make monerod stagenet usage resilient (tari-project#3572) feat: add atomic swap htlc sending and claiming (tari-project#3552) feat: implement prometheus metrics for base node (tari-project#3563) feat: implement multiple read single write for sqlite (tari-project#3568) feat: trigger time lock balance update when block received (tari-project#3567) test: reduce cucumber ci to critical only (tari-project#3566) test: fix cucumber console wallet startup (tari-project#3564) chore: add node id/public key to log mdc (tari-project#3559) fix: avoid implicit using of the time crate (tari-project#3562) feat: one-click installer - cli edition (tari-project#3534) ci: add workflow dispatch to libwallet build action (tari-project#3556) fix: stop leak of value of recovered output (tari-project#3558) ...
Description
metrics
feature to base node and tari_commscommon.metrics
get-network-stats
commandMotivation and Context
Increase base node visibility
Dependencies
warp
for http metric pull serverreqwest
for metric push clientprometheus
for instrumentationHow Has This Been Tested?
Manually
docker run --rm -it -p 9090:9090 -v `pwd`/prometheus.yml:/etc/prometheus/prometheus.yml prom/prometheus
--metrics-bind-addr 127.0.0.1:5544
localhost:9090