fix: randomx memory usage #3301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 6, 2021
Removed dataset from RandomXVMInstance, light mode only requires a cache, this fixes a bug where light mode will consume more than 256MB of memory per RandomXVMInstance. Made RandomXDataset optional for RandomXVMInstance. cargo-fmt Comments
StriderDM
force-pushed
the
randomx_fast_mode_fix
branch
from
1815ea1
to
6301564
Compare
|
Nice one! Will test |
sdbondi
approved these changes
Sep 6, 2021
stringhandler
approved these changes
Sep 6, 2021
| // Note: If a cache and dataset (if assigned) allocated to the VM drops, the VM will crash. | ||
| // The cache and dataset for the VM need to be stored together with it since they are not | ||
| // mix and match. | ||
| instance: Arc<Mutex<(RandomXVM, RandomXCache, Option<RandomXDataset>)>>, |
There was a problem hiding this comment.
Why keep the dataset in here if it's always set to None?
Cifko
pushed a commit
to Cifko/tari
that referenced
this pull request
Sep 10, 2021
Description Removed dataset from RandomXVMInstance, light mode only requires a cache, this fixes a bug where light mode will consume more than 256MB of memory per RandomXVMInstance. Made RandomXDataset optional for RandomXVMInstance. resolves tari-project#3104 closes tari-project#3103 Motivation and Context Overall memory overhead reduction How Has This Been Tested? Manually in a constrained vagrant instance <img width="1048" alt="Screen Shot 2021-09-04 at 12 45 40 AM" src="https://user-images.githubusercontent.com/51991544/132176934-6a5a3753-4960-472c-8544-edebd6eec40d.png">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed dataset from RandomXVMInstance, light mode only requires a cache, this fixes a bug where light mode will consume more than 256MB of memory per RandomXVMInstance.
Made RandomXDataset optional for RandomXVMInstance.
resolves #3104
closes #3103
Motivation and Context
Overall memory overhead reduction
How Has This Been Tested?
Manually in a constrained vagrant instance