Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove openssl from windows runtime #3242

Conversation

hansieodendaal
Copy link
Contributor

Description

  • Removed OpenSSL installers and dependencies from Windows runtime
  • Removed stdout as appender from console wallet's log4rs logger

Motivation and Context

  • OpenSSL is not a Windows runtime dependency anymore
  • The console wallet cannot handle log4rs logger messages to its stdout as it breaks the TUI

How Has This Been Tested?

Build the installer, ran an installer, ran all the executable components

- Removed OpenSSL installers and dependencies from Windows runtime
- Removed stdout as appender from console wallet's log4rs logger
Copy link
Contributor

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Haven't tested but looks good.

@stringhandler stringhandler merged commit 0048c3b into tari-project:development Aug 26, 2021
@hansieodendaal hansieodendaal deleted the ho_remove_openssl_windows branch August 30, 2021 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants