Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky unit test sending_transaction_and_confirmation #3179

Merged
merged 2 commits into from
Aug 11, 2021
Merged

test: fix flaky unit test sending_transaction_and_confirmation #3179

merged 2 commits into from
Aug 11, 2021

Conversation

SWvheerden
Copy link
Collaborator

Description

The unit test had 2 edge cases:

  1. When the transaction had no change, the master_key index should be 0 and not 1.
  2. Inside of the builder we had an edge case of one check being >= while the next check being > which resulted in the tx builder thinking it did not have enough funds

Motivation and Context

How Has This Been Tested?

Checklist:

  • I'm merging against the development branch.
  • I have squashed my commits into a single commit.

sdbondi
sdbondi approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@stringhandler stringhandler changed the title fix: Fix flaky unit test sending_transaction_and_confirmation test: fix flaky unit test sending_transaction_and_confirmation Aug 11, 2021
@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 11, 2021

PR queued successfully. Your position in queue is: 4

@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 11, 2021

PR is on top of the queue now

@aviator-app aviator-app bot merged commit a422400 into tari-project:development Aug 11, 2021
@SWvheerden SWvheerden deleted the sw_fix_flaky_test branch August 12, 2021 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stringhandler stringhandler stringhandler approved these changes

@sdbondi sdbondi sdbondi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SWvheerden @sdbondi @stringhandler