feat: add network selection to wallet_ffi #3178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StriderDM
force-pushed
the
wallet_ffi_network_selection
branch
from
47aeefb to
e11cade
Compare
This was referenced Aug 10, 2021
philipr-za
reviewed
Aug 11, 2021
StriderDM
force-pushed
the
wallet_ffi_network_selection
branch
from
e11cade to
7246076
Compare
stringhandler
previously approved these changes
Aug 12, 2021
stringhandler
changed the title
|
PR queued successfully. Your position in queue is: 3 |
|
PR is on top of the queue now |
|
PR failed to merge with reason: Merge conflict |
Update lib.rs Review comments
StriderDM
force-pushed
the
wallet_ffi_network_selection
branch
from
7246076 to
d55bff0
Compare
|
Waiting for approval before queuing |
philipr-za
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Network selection for mobile wallets
Note: Breaking change for mobile wallets.
Motivation and Context
Network selection for mobile wallets
How Has This Been Tested?
cargo test
Checklist:
developmentbranch.