feat: wallet connectivity service #3159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
wallet-use-rpc-pool
branch
from
72a05fd to
5449c4c
Compare
2 tasks
sdbondi
changed the title
sdbondi
force-pushed
the
wallet-use-rpc-pool
branch
6 times, most recently
from
7d12fa3 to
1930a16
Compare
sdbondi
changed the title
sdbondi
force-pushed
the
wallet-use-rpc-pool
branch
4 times, most recently
from
483c545 to
4049968
Compare
Adds a service responsible for wallet connectivity. This service is responsible for and abstracts any complexity in the management of the base node connections and RPC session management. This PR makes use of this service in the base node montoring service but does not "plumb" the WalletConenctivityService into the protocols. This is left as a TODO, but we should expect this to remove many lines of code and greaty simplify these protocols by removing the budren of connection management in the various wallet components. A number of simplifications on the peer connection and substream code, debatably reducing places that bugs could hide.
sdbondi
force-pushed
the
wallet-use-rpc-pool
branch
from
4049968 to
e1e0f0c
Compare
stringhandler
approved these changes
Aug 10, 2021
|
PR queued successfully. Your position in queue is: 1 |
|
Yeah I named it that after initially naming it create_... just because the semantics of this call is not to necessarily create one but to somehow obtain one ("I don't care how/when just give me an RPC connection") - from a pool of existing connections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a service responsible for wallet connectivity. This service
is responsible for and abstracts any complexity in the management of
the base node connections and RPC session management.
This PR makes use of this service in the base node montoring service but
does not "plumb" the WalletConenctivityService into the protocols. This
is left as a TODO, but we should expect this to remove many lines of
code and greaty simplify these protocols by removing the budren of
connection management in the various wallet components.
A number of simplifications on the peer connection and substream code,
debatably reducing places that bugs could hide.
Motivation and Context
Follow on from #3152, making use of the pool in the wallet base node monitoring. The rest of the protocols should follow.
How Has This Been Tested?
Extensive service unit tests
Existing tests pass
Washing machine test on local wallet, with the broadcast protocol modified to use the wallet connectivity
Base node RPC sessions max out at 10 each (2 wallets connected to same base node) even when pushing through 426 transactions.
Manually tested wallet connectivity states (Connecting -> Online | Connecting -> Offline | Connecting -> Online -> Offline -> Connecting -> Online)
Checklist:
developmentbranch.