fix: replace usage of RangeProof MR with Witness MR #3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
reviewed
Jul 22, 2021
| #[error("Invalid range proof merkle root")] | ||
| InvalidRangeProofMr, | ||
| #[error("Invalid witness merkle root")] | ||
| InvalidWitnessMr, |
There was a problem hiding this comment.
This variant isnt used (assuming everything compiles) and can be removed. Did a quick search and same for InvalidKernelMr and InvalidOutputMr can be removed
There was a problem hiding this comment.
...and WeakerAccumulatedDifficulty, they are all handled in BlockError(..) and PowError(...)
stringhandler
previously approved these changes
Jul 23, 2021
|
PR queued successfully. Your position in queue is: 2 |
SWvheerden
force-pushed
the
sw_fix_naming_witnessmr
branch
from
cdab964
to
21b886b
Compare
remove unused errors
SWvheerden
force-pushed
the
sw_fix_naming_witnessmr
branch
from
21b886b
to
88548f9
Compare
|
PR is on top of the queue now |
|
PR failed to merge with reason: Not approved |
stringhandler
approved these changes
Jul 23, 2021
sdbondi
approved these changes
Jul 24, 2021
|
PR queued successfully. Your position in queue is: 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are still some names references a rangeproof Mr, this does not exist anymore and there is only a witness Mr.
Motivation and Context
How Has This Been Tested?
Checklist:
developmentbranch.