fix: remove extra range proof verifications #6190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 120 suites 35m 53s ⏱️ Results for commit 1def6c9. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests)29 tests 29 ✅ 11m 49s ⏱️ Results for commit 1def6c9. |
SWvheerden
approved these changes
Mar 7, 2024
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes extra range proof verifications that are done if batch verification fails.
Motivation and Context
If a batch of range proofs fails verification, each proof is checked separately until an invalid proof is found; this is reported for debugging purposes, but is otherwise not used.
This is inefficient and can lead to denial of service.
Until (or unless) #6167 is implemented to provide a more efficient method of identifying an invalid proof, this PR removes the unused extra verification operations.
How Has This Been Tested?
Existing tests pass.
What process can a PR reviewer use to test or verify this change?
Confirm that the existing verification operations were unused (except for debugging purposes), and that batch verification continues to work as expected.