-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: do validation after adding utxos and txs #6114
feat: do validation after adding utxos and txs #6114
Conversation
Test Results (CI)1 268 tests 1 268 ✅ 18m 0s ⏱️ Results for commit d88658e. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a better place to add this would be here if num_outputs_recovered>0
?
match self.get_next_peer() {
Some(peer) => match self.attempt_sync(peer.clone()).await {
Ok((num_outputs_recovered, final_height, final_amount, elapsed)) => {
debug!(target: LOG_TARGET, "Scanned to height #{}", final_height);
self.finalize(num_outputs_recovered, final_height, final_amount, elapsed)?;
return Ok(());
},
Err(e) => {
warn!(
target: LOG_TARGET,
"Failed to scan UTXO's from base node {}: {}", peer, e
);
self.publish_event(UtxoScannerEvent::ScanningRoundFailed {
num_retries: self.num_retries,
retry_limit: self.retry_limit,
error: e.to_string(),
});
continue;
},
},
I also see there are some failing unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Description
Trigger a validation task after recovery of outputs
Motivation and Context
During testing, new outputs are added slower than validation and an edge case occurs where outputs will only be validated after a new block is added again.