Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: display #5982

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix: display #5982

merged 1 commit into from
Dec 1, 2023

Conversation

SWvheerden
Copy link
Collaborator

@SWvheerden SWvheerden commented Nov 23, 2023 •
edited
Loading

Description

  • Fix display panic in base_layer/core/src/mempool/service/request.rs. When a transaction without a kernel comes in, this will panic
  • Fix display to no longer call FixedHash to hex, as fixedhash already impl display.

@github-actions GitHub Actions
Copy link

Test Results (CI)

1 249 tests   1 249 ✔️  10m 38s ⏱️
     39 suites         0 💤
       1 files           0 ❌

Results for commit d730dc5.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Nov 23, 2023
@github-actions GitHub Actions
Copy link

Test Results (Integration tests)

  2 files  11 suites   43m 48s ⏱️
31 tests 30 ✔️ 0 💤 1 ❌
33 runs  31 ✔️ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit d730dc5.

hansieodendaal
hansieodendaal approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Dec 1, 2023
@SWvheerden SWvheerden merged commit 8cce48c into tari-project:development Dec 1, 2023
15 of 16 checks passed
@SWvheerden SWvheerden deleted the sw_fix_display_dev branch December 1, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansieodendaal hansieodendaal hansieodendaal approved these changes

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SWvheerden @hansieodendaal @ghpbot-tari-project