feat: compile out the metrics #5944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
SWvheerden
approved these changes
Nov 13, 2023
ghpbot-tari-project
removed
the
P-reviews_required
SWvheerden
pushed a commit
that referenced
this pull request
Nov 14, 2023
Description --- Does minor refactoring of metrics-only blocks to make the analyzer happy. Motivation and Context --- Recent work in #5944 makes metrics a non-default feature. This made the analyzer unhappy due to some unused variables, but it turns out this can be fixed while simplifying some of the handling of metrics-only blocks. This PR makes these changes and keeps the analyzer happy. How Has This Been Tested? --- Existing tests pass. What process can a PR reviewer use to test or verify this change? --- Check that the new metrics-only block handling is identical to that introduced by #5944.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not merge until testing is complete
We made metric features in the applications a compiler option but core was still including it all by default.
I had wanted to do something more elegant like swap in a mock for the metrics system which would have hopefully required less sprinkles of changes, but the metrics are currently being used to return types from the metrics system and operate on them. This is still possible to phase out but would take more time due to the need to refactor all the existing metrics modules.
Motivation and Context
Metrics should be opt-in, and not on by default.
How Has This Been Tested?
Mobile team is testing it now.
Breaking Changes