Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the windows installer #5938

Merged

Conversation

hansieodendaal
Copy link
Contributor

Description

Fixed the Windows installer whereby the merge mining proxy batch file had the wrong prefix - _tari_ instead of _minitari_.

Motivation and Context

The merge mining proxy did not start using the menu.

How Has This Been Tested?

Install test

What process can a PR reviewer use to test or verify this change?

Install test, then start the merge mining proxy via the menu

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

Fixed the Windows installer whereby the merge mining proxy batch file had the
wrong prefix - `_tari_` instead of `_minitari_`.
Copy link

Test Results (CI)

1 253 tests   1 253 ✔️  9m 36s ⏱️
     39 suites         0 💤
       1 files           0

Results for commit eebcc96.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Nov 10, 2023
Copy link

Test Results (Integration tests)

31 tests  +31   31 ✔️ +31   14m 21s ⏱️ + 14m 21s
11 suites +11     0 💤 ±  0 
  2 files   +  2     0 ±  0 

Results for commit eebcc96. ± Comparison against base commit 27f78de.

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Nov 10, 2023
@SWvheerden SWvheerden merged commit 3e65a28 into tari-project:development Nov 10, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants