feat!: fix difficulty overflow #5935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files + 2 11 suites +11 16m 59s ⏱️ + 16m 59s For more details on these failures, see this check. Results for commit 8ff6354. ± Comparison against base commit 27f78de. ♻️ This comment has been updated with latest results. |
AaronFeickert
requested changes
Nov 9, 2023
base_layer/core/src/base_node/chain_metadata_service/service.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Aaron Feickert <[email protected]>
Co-authored-by: Aaron Feickert <[email protected]>
Co-authored-by: Aaron Feickert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increases the accumulated algo difficulty from u64 ti u128.
Increases the total accumulated difficulty from u128 to u256.
Motivation and Context
Having block difficulty as u64 and accumulated difficulty as u64 will overflow.
See: #5851
How Has This Been Tested?
unit tests
Fixes: #5851