feat: enable multiple coinbase utxos #5879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files + 2 11 suites +11 13m 37s ⏱️ + 13m 37s For more details on these failures, see this check. Results for commit 418cfa9. ± Comparison against base commit 5c2781e. ♻️ This comment has been updated with latest results. |
SWvheerden
force-pushed
the
sw_mult_coinbases
branch
from
8fb78fe
to
42ed224
Compare
|
We have enough test cases that already test for duplicate coinbase utxos and duplicate coinbase kernels, they all handle correctly. We don't have to add anything extravagant here atm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows multiple coinbase utxos in a block
Motivation and Context
If we want to implement p2pool, implementing multiple coinbases is the easiest way to enable multiple parties to have their own verified UTXOs mined. There are other ways of doing this, but this approach is the simplest and requires the least overall utxos.
How Has This Been Tested?
unit tests