feat: failure of min difficulty should not add block to list of bad blocks

[SWvheerden]

Description

Blocks that fail min difficulty should not be added to the list of bad blocks.

Motivation and Context

By adding the blocks to the list of bad blocks we open up the local node to be spammed to write bad block hashes into the database. These waste space and they require a write lock on the database. Checking the difficulty is a very quick and inexpensive check.

[github-actions]

Test Results (CI)

1 219 tests   1 219 ✔️  9m 31s ⏱️
     39 suites         0 💤
       1 files           0 ❌

Results for commit 385dc66.

♻️ This comment has been updated with latest results.

[github-actions]

Test Results (Integration tests)

  2 files  +  2  11 suites  +11   20m 59s ⏱️ + 20m 59s
33 tests +33  29 ✔️ +29  0 💤 ±0  4 ❌ +4 
39 runs  +39  32 ✔️ +32  0 💤 ±0  7 ❌ +7 

For more details on these failures, see this check.

Results for commit 385dc66. ± Comparison against base commit 05fc2e9.

♻️ This comment has been updated with latest results.

[brianp]

The code change itself is fine. But the PR is really easy to misinterpret:

Blocks that fail min difficulty are not added to the list of bad blocks.

Is this a problem statement that the PR addresses Or the solution the PR proposes. Should I expect to see a codechange that adds the bad blocks to the list or doesn't?

Reading the motivation and context offers more information, but again it's not immediately apparent what direction the code change will go, or whether it will be added to the list or not.