fix: chat ffi seed peers #5786
Merged
fix: chat ffi seed peers #5786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
SWvheerden
previously approved these changes
Sep 19, 2023
ghpbot-tari-project
removed
the
P-reviews_required
ghpbot-tari-project
added
the
P-reviews_required
brianp
force-pushed
the
build-ffis-fix-chat-ffi-seed-peers
branch
from
d4aab58
to
b7de7ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we reconfigured the configuration (:D) for chat to allow for easier seed peer setting in the FFI, but I forgot to apply the boolean for using DNS peers.
Motivation and Context
Get peers on ffi.
How Has This Been Tested?
With disposable tests in cucumber locally, and CI
Breaking Changes