fix: potential overflow #5778
Merged
fix: potential overflow #5778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
There was a problem hiding this comment.
While this PR is only changing a specific addition, there are a lot of the files that are touched that have similar overflow problems. Specifically, in the mempool there are a number of these unchecked additions. I would suggest rather fix all the additions/multiplies in the mempool in this PR, otherwise, it's difficult to approve when there are glaring potential overflows
base_layer/core/src/mempool/priority/prioritized_transaction.rs
Outdated
Show resolved
Hide resolved
base_layer/core/src/mempool/priority/prioritized_transaction.rs
Outdated
Show resolved
Hide resolved
base_layer/core/src/mempool/unconfirmed_pool/unconfirmed_pool.rs
Outdated
Show resolved
Hide resolved
stringhandler
approved these changes
Oct 12, 2023
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes potential overflow from fee calculation
Motivation and Context
The transaction comes from remove peers, if the fee is u64::Max this can overflow and panic the node.