Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add insert function to SMT #5776

Merged
merged 4 commits into from
Sep 20, 2023
Merged

feat: add insert function to SMT #5776

merged 4 commits into from
Sep 20, 2023

Conversation

SWvheerden
Copy link
Collaborator

Description

Adds a new insert function to only add a leaf if it already exists.

Motivation and Context

If this is used for an unspent UTXO set we want it to disallow duplicate UTXOs

How Has This Been Tested?

unit tests

@github-actions
Copy link

github-actions bot commented Sep 15, 2023 •
edited
Loading

Test Results (CI)

1 216 tests   1 216 ✔️  9m 54s ⏱️
     39 suites         0 💤
       1 files           0 ❌

Results for commit 0d346e1.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Sep 15, 2023
@github-actions
Copy link

github-actions bot commented Sep 15, 2023 •
edited
Loading

Test Results (Integration tests)

29 tests   29 ✔️  13m 6s ⏱️
11 suites    0 💤
  2 files      0 ❌

Results for commit 0d346e1.

♻️ This comment has been updated with latest results.

AaronFeickert
AaronFeickert requested changes Sep 15, 2023
View reviewed changes
base_layer/mmr/src/sparse_merkle_tree/tree.rs Outdated Show resolved Hide resolved
base_layer/mmr/src/sparse_merkle_tree/tree.rs Outdated Show resolved Hide resolved
@CjS77
Copy link
Collaborator

CjS77 commented Sep 18, 2023

Concept ACK

CjS77
CjS77 approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@CjS77 CjS77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CjS77 CjS77 added the P-merge Process - Queued for merging label Sep 19, 2023
@CjS77 CjS77 merged commit 5901b4a into tari-project:development Sep 20, 2023
13 checks passed
@SWvheerden SWvheerden deleted the sw_add_insert_function branch September 26, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronFeickert AaronFeickert AaronFeickert approved these changes

@CjS77 CjS77 CjS77 approved these changes

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs P-merge Process - Queued for merging P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SWvheerden @CjS77 @AaronFeickert @ghpbot-tari-project