fix: change truncate_from_bits to from_bits #5773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
reviewed
Sep 14, 2023
There was a problem hiding this comment.
utACK but since RpcFlags are not part of blockchain data this does limit some upgrade paths. Say we wanted to add a new optional flag to RPC that e.g. enables an optimisation for newer nodes, we could do that without breaking existing nodes. With this change we'll need to wait until sufficient have upgraded.
I can't think of a risk of truncating here given that this is a message flag for an ephemeral/non-persistent/not-hashed message.
|
Yeah we may revert this when we add new flags, but I think for now let's err on the side of caution and use |
ghpbot-tari-project
added
P-acks_required
ghpbot-tari-project
removed
the
P-reviews_required
sdbondi
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes all occurrences of
truncate_from_bitstofrom_bitsMotivation and Context
truncate_from_bitswill truncate all unknown bits and may cause bits to be interpreted as the wrong flag. This changes to the much more strictfrom_bitswhich forces peers to use the correct bits and only the correct bits.