Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unwraps in rpc client #5770

Merged
merged 2 commits into from
Sep 14, 2023
Merged

fix: unwraps in rpc client #5770

merged 2 commits into from
Sep 14, 2023

Conversation

SWvheerden
Copy link
Collaborator

Description

Removes unwraps in the rpc client code

Motivation and Context

There should not be unwraps, and they should propagate errors on invalid data

sdbondi
sdbondi previously approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sheesh, introduced in PR #3961 - good catch

@ghpbot-tari-project ghpbot-tari-project added the P-acks_required Process - Requires more ACKs or utACKs label Sep 14, 2023
@github-actions
Copy link

github-actions bot commented Sep 14, 2023 •
edited
Loading

Test Results (CI)

1 214 tests   1 214 ✔️  10m 48s ⏱️
     39 suites         0 💤
       1 files           0 ❌

Results for commit 2f91358.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Sep 14, 2023
@github-actions
Copy link

Test Results (Integration tests)

  2 files  11 suites   14m 16s ⏱️
28 tests 27 ✔️ 0 💤 1 ❌
29 runs  28 ✔️ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 2f91358.

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Sep 14, 2023
@SWvheerden SWvheerden merged commit 6f0d20a into tari-project:development Sep 14, 2023
12 of 13 checks passed
@SWvheerden SWvheerden deleted the sw_fixunwraps branch September 14, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdbondi sdbondi sdbondi approved these changes

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SWvheerden @sdbondi @ghpbot-tari-project