Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle possible underflow in smt #5769

Merged
merged 1 commit into from
Sep 14, 2023
Merged

fix: handle possible underflow in smt #5769

merged 1 commit into from
Sep 14, 2023

Conversation

CjS77
Copy link
Collaborator

@CjS77 CjS77 commented Sep 14, 2023

A few unchecked subtractions are replaced with checked alternatives.

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@CjS77
fix: handle possible underflow in smt
0121fef 
A few unchecked subtractions are replaced with checked alternatives.
@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Sep 14, 2023
@github-actions
Copy link

Test Results (CI)

1 214 tests   1 214 ✔️  10m 27s ⏱️
     39 suites         0 💤
       1 files           0 ❌

Results for commit 0121fef.

@github-actions
Copy link

Test Results (Integration tests)

28 tests   28 ✔️  13m 14s ⏱️
11 suites    0 💤
  2 files      0 ❌

Results for commit 0121fef.

SWvheerden
SWvheerden approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Sep 14, 2023
@SWvheerden SWvheerden merged commit 558e6f2 into development Sep 14, 2023
13 checks passed
@CjS77 CjS77 deleted the smt-underflow branch February 21, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SWvheerden SWvheerden SWvheerden approved these changes

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CjS77 @SWvheerden @ghpbot-tari-project