Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: potential sync stuck #5760

Merged

Conversation

SWvheerden
Copy link
Collaborator

Description

Fixes a potential case where sync process can get stuck

Motivation and Context

There exists a potential where latency keeps increasing forever and the local node will be stuck in sync forever. This adds in a max amount of times the local node will try again before exiting.

@github-actions
Copy link

Test Results (CI)

1 200 tests   1 200 ✔️  10m 6s ⏱️
     38 suites         0 💤
       1 files           0

Results for commit 427d296.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Sep 11, 2023
@github-actions
Copy link

Test Results (Integration tests)

27 tests  +27   27 ✔️ +27   13m 39s ⏱️ + 13m 39s
11 suites +11     0 💤 ±  0 
  2 files   +  2     0 ±  0 

Results for commit 427d296. ± Comparison against base commit 45c20a3.

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghpbot-tari-project ghpbot-tari-project removed P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Sep 12, 2023
@SWvheerden SWvheerden merged commit c5ed816 into tari-project:development Sep 12, 2023
11 checks passed
@SWvheerden SWvheerden deleted the sw_fix_potential_header_stuck branch September 26, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants