feat(chatffi): tor configuration #5752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianp
force-pushed
the
feat-chatffi-tor-config
branch
from
5f72108
to
b916646
Compare
brianp
force-pushed
the
feat-chatffi-tor-config
branch
from
b916646
to
ddd5f70
Compare
ghpbot-tari-project
added
P-acks_required
brianp
changed the title
Test Results (Integration tests) 2 files + 2 11 suites +11 15m 30s ⏱️ + 15m 30s For more details on these failures, see this check. Results for commit 3b29409. ± Comparison against base commit 45c20a3. ♻️ This comment has been updated with latest results. |
SWvheerden
reviewed
Sep 7, 2023
base_layer/chat_ffi/src/lib.rs
Outdated
| @@ -69,6 +71,9 @@ mod consts { | |||
| include!(concat!(env!("OUT_DIR"), "/consts.rs")); | |||
| } | |||
|
|
|||
| #[derive(Debug, PartialEq, Clone)] | |||
| pub struct ByteVector(Vec<c_uchar>); // declared like this so that it can be exposed to external header | |||
There was a problem hiding this comment.
if it needs exposing, then it needs rep_c as well?
There was a problem hiding this comment.
I copied it verbatim from the wallet, which doesn't use rep_c for it.
Which is a roundabout way of saying I'm hesitant to "fix" something not broken :D
brianp
changed the title
SWvheerden
approved these changes
Sep 12, 2023
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow more configuration options for TOR
Motivation and Context
Mobile doesn't align with the tor transport config defaults that were being applied, so let's allow for a specific configuration.
How Has This Been Tested?
CI
Breaking Changes