feat(p2p): allow listener bind to differ from the tor forward address #5357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
changed the title
ghpbot-tari-project
added
P-acks_required
sdbondi
force-pushed
the
p2p-configurable-listener-with-tor-transport
branch
from
1323736
to
a46555a
Compare
sdbondi
force-pushed
the
p2p-configurable-listener-with-tor-transport
branch
from
a46555a
to
20c9781
Compare
sdbondi
changed the title
stringhandler
approved these changes
May 2, 2023
ghpbot-tari-project
removed
the
P-reviews_required
SWvheerden
added a commit
that referenced
this pull request
May 8, 2023
## [0.50.0-pre.1](v0.50.0-pre.0...v0.50.0-pre.1) (2023-05-08) ### Features * add miner timeout config option ([5331](#5331)) ([aea14f6](aea14f6)) * chat ffi ([5349](#5349)) ([f7cece2](f7cece2)) * chat scaffold ([5244](#5244)) ([5b09f8e](5b09f8e)) * improve message encryption ([5288](#5288)) ([7a80716](7a80716)) * **p2p:** allow listener bind to differ from the tor forward address ([5357](#5357)) ([857fb55](857fb55)) ### Bug Fixes * add SECURITY.md Vulnerability Disclosure Policy ([5351](#5351)) ([72daaf5](72daaf5)) * added missing log4rs features ([5356](#5356)) ([b9031bb](b9031bb)) * allow public addresses from command line ([5303](#5303)) ([349ac89](349ac89)) * clippy issues with config ([5334](#5334)) ([026f0d5](026f0d5)) * default network selection ([5333](#5333)) ([cf4b2c8](cf4b2c8)) * make the first output optional in the wallet ([5352](#5352)) ([bf16140](bf16140)) * remove wallet panic ([5338](#5338)) ([536d16d](536d16d)) * wallet .h file for lib wallets ([5330](#5330)) ([22a3a17](22a3a17))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
p2p.tor.listener_address_overrideconfig to allow a listener bind address that differs from the forward_address for incoming tor connections.Motivation and Context
This is useful for docker setups where containers are addressed by DNS. In this case, the forward_address would be
/dns4/my_base_node/tcp/xxxxxand thelistener_address_override="/ip4/0.0.0.0/tcp/xxxxx"How Has This Been Tested?
Manually by setting the override to
"/ip4/0.0.0.0/tcp/12345"and the forward_address to/dns4/localhost/tcp/12345What process can a PR reviewer use to test or verify this change?
Breaking Changes