feat: add network name to data path and --network flag to the miners #5291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWvheerden
reviewed
Apr 11, 2023
brianp
force-pushed
the
fix-default-ports
branch
from
0327564
to
ba4d269
Compare
ghpbot-tari-project
added
P-acks_required
All of our apps use this flag now so it makes sense to pull out into the common cli args.
brianp
force-pushed
the
fix-default-ports
branch
from
ba4d269
to
38758e7
Compare
brianp
force-pushed
the
fix-default-ports
branch
from
38758e7
to
66a29fe
Compare
ghpbot-tari-project
removed
the
P-reviews_required
SWvheerden
changed the title
SWvheerden
changed the title
SWvheerden
added a commit
that referenced
this pull request
Apr 12, 2023
## [0.50.0-pre.0](v0.49.0-pre.6...v0.50.0-pre.0) (2023-04-12) ### ⚠ BREAKING CHANGES * add paging to utxo stream request (5302) ### Features * add extended mask recovery ([5301](#5301)) ([23d882e](23d882e)) * add network name to data path and --network flag to the miners ([5291](#5291)) ([1f04beb](1f04beb)) * add other code template types ([5242](#5242)) ([93e5e85](93e5e85)) * add paging to utxo stream request ([5302](#5302)) ([3540309](3540309)) * add wallet daemon config ([5311](#5311)) ([30419cf](30419cf)) * define different network defaults for bins ([5307](#5307)) ([2f5d498](2f5d498)) * feature gates ([5287](#5287)) ([72c19dc](72c19dc)) * fix rpc transaction conversion ([5304](#5304)) ([344040a](344040a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does two jobs (sorry). Mostly because they're dependent tasks.
--networkto the miners for simple setting switchesMotivation and Context
This can be used to help select the default ports of communication for the base node and wallet, and also easily keeping network id's and folders separate.
How Has This Been Tested?
Manually
What process can a PR reviewer use to test or verify this change?
Run a base node, wallet, and miner. Set a base directory path as something like
-b ./data/mytestand the network to igor--network igorand watch in amazement as the data directory./data/mytest/igor/is created to store information.Closes #5272
Closes #5273
Breaking Changes