feat!: move key manager service to key_manager #5284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWvheerden
force-pushed
the
sw_move_key_manager
branch
2 times, most recently
from
cd212d5
to
9f83659
Compare
SWvheerden
force-pushed
the
sw_move_key_manager
branch
from
9f83659
to
cc41b5d
Compare
stringhandler
previously approved these changes
Apr 5, 2023
ghpbot-tari-project
added
the
P-acks_required
stringhandler
previously approved these changes
Apr 5, 2023
stringhandler
approved these changes
Apr 5, 2023
SWvheerden
added a commit
that referenced
this pull request
Apr 5, 2023
## [0.49.0-pre.6](v0.49.0-pre.5...v0.49.0-pre.6) (2023-04-05) ### ⚠ BREAKING CHANGES * move key manager service to key_manager (5284) * add igor faucet (5281) * reset dates for networks (5283) ### Features * add igor faucet ([5281](#5281)) ([bfc92fd](bfc92fd)) * added auxiliary callback to push base node state changes [5109](#5109) ([#5257](#5257)) ([b7f7d31](b7f7d31)) * move key manager service to key_manager ([5284](#5284)) ([d50ed02](d50ed02)) * reset dates for networks ([5283](#5283)) ([d6342a4](d6342a4)) ### Bug Fixes * resize transaction tab windows ([5290](#5290)) ([bd95a85](bd95a85)), closes [#4942](#4942) [#5289](#5289) [#12365](https://github.com/tari-project/tari/issues/12365)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the key_manager_services to key_manager_create
Motivation and Context
Currently, all transactions are built by supplying private keys to the constructor. The wallet implements a Key_manager_service that safely constructs the private key but this is then passed around in code to where it is used to sign transactions etc.
We want to refactor this, that the code only ask for a signature and not a private key. This means the private key generation should happen where core can access it. This will be refactored in a future PR. This is part of allowing support of Hardware devices in the future.
How Has This Been Tested?
Unit tests and manual tx sending
Breaking Changes
Requires data directory to be deleted on the wallet
BREAKING CHANGE: Requires data directory to be deleted on the wallet because it changes how the wallet database structure looks.