Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change data dir to include network name #5273

Closed
SWvheerden opened this issue Mar 28, 2023 · 2 comments · Fixed by #5291
Closed

Change data dir to include network name #5273

SWvheerden opened this issue Mar 28, 2023 · 2 comments · Fixed by #5291
Assignees
Labels
A-base_node Area - The Tari base node executable and libraries A-wallet Area - related to the wallet

Comments

@SWvheerden
Copy link
Collaborator

SWvheerden commented Mar 28, 2023

Change the data directory behavior to include the network name.
Currently, the folder structure looks as follows:

dir
     config
     data
     peer-db

This should be changed to be:

dir/{network_name}
                  config
                  data
                  peer-db
@SWvheerden SWvheerden added A-base_node Area - The Tari base node executable and libraries A-wallet Area - related to the wallet labels Mar 28, 2023
@SWvheerden SWvheerden moved this to Must Do in Tari Esme Testnet Mar 28, 2023
@SWvheerden SWvheerden moved this from Must Do to Selected for development in Tari Esme Testnet Apr 3, 2023
@brianp brianp moved this from Selected for development to In Progress in Tari Esme Testnet Apr 4, 2023
@hnidoaht-101
Copy link
Contributor

Does anyone work on it yet? Otherwise, I'd like to resolve this.

@SWvheerden
Copy link
Collaborator Author

I think @brianp is.

@brianp brianp moved this from In Progress to In Review in Tari Esme Testnet Apr 12, 2023
SWvheerden added a commit that referenced this issue Apr 12, 2023
…5291)

Description
---
This PR does two jobs (sorry). Mostly because they're dependent tasks.

- Add `--network` to the miners for simple setting switches
- Add the network into the data directory path

Motivation and Context
---
This can be used to help select the default ports of communication for
the base node and wallet, and also easily keeping network id's and
folders separate.

How Has This Been Tested?
---
Manually

What process can a PR reviewer use to test or verify this change?
---
Run a base node, wallet, and miner. Set a base directory path as
something like `-b ./data/mytest` and the network to igor `--network
igor` and watch in amazement as the data directory `./data/mytest/igor/`
is created to store information.

Closes #5272
Closes #5273

Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->

---------

Co-authored-by: SW van Heerden <[email protected]>
@github-project-automation github-project-automation bot moved this from In Review to Done in Tari Esme Testnet Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-base_node Area - The Tari base node executable and libraries A-wallet Area - related to the wallet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants