-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change data dir to include network name #5273
Labels
A-base_node
Area - The Tari base node executable and libraries
A-wallet
Area - related to the wallet
Comments
SWvheerden
added
A-base_node
Area - The Tari base node executable and libraries
A-wallet
Area - related to the wallet
labels
Mar 28, 2023
Does anyone work on it yet? Otherwise, I'd like to resolve this. |
I think @brianp is. |
4 tasks
SWvheerden
added a commit
that referenced
this issue
Apr 12, 2023
…5291) Description --- This PR does two jobs (sorry). Mostly because they're dependent tasks. - Add `--network` to the miners for simple setting switches - Add the network into the data directory path Motivation and Context --- This can be used to help select the default ports of communication for the base node and wallet, and also easily keeping network id's and folders separate. How Has This Been Tested? --- Manually What process can a PR reviewer use to test or verify this change? --- Run a base node, wallet, and miner. Set a base directory path as something like `-b ./data/mytest` and the network to igor `--network igor` and watch in amazement as the data directory `./data/mytest/igor/` is created to store information. Closes #5272 Closes #5273 Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain --> --------- Co-authored-by: SW van Heerden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-base_node
Area - The Tari base node executable and libraries
A-wallet
Area - related to the wallet
Change the data directory behavior to include the network name.
Currently, the folder structure looks as follows:
This should be changed to be:
The text was updated successfully, but these errors were encountered: