Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI - Fix wasm pack install #5261

Closed
SWvheerden opened this issue Mar 21, 2023 · 1 comment
Closed

CI - Fix wasm pack install #5261

SWvheerden opened this issue Mar 21, 2023 · 1 comment
Labels
A-ci Area - Continuous Integration related

Comments

@SWvheerden
Copy link
Collaborator

Since commit 1c65bc7
Wasm pack has been broken for CI
This needs to be fixed again and re-added.

Fails with:

found 0 vulnerabilities
info: downloading component 'rust-std' for 'wasm32-unknown-unknown'
info: installing component 'rust-std' for 'wasm32-unknown-unknown'
rustup run nightly-[20](https://github.com/tari-project/tari/actions/runs/4467454060/jobs/7847682092#step:5:21)[22](https://github.com/tari-project/tari/actions/runs/4467454060/jobs/7847682092#step:5:23)-11-03 wasm-pack test --node --features wasm
error: command failed: 'wasm-pack': No such file or directory (os error 2)
make: *** [test] Error 1
Makefile:5: recipe for target 'test' failed
Error: Process completed with exit code 2.
@SWvheerden SWvheerden added the A-ci Area - Continuous Integration related label Mar 21, 2023
@AaronFeickert AaronFeickert mentioned this issue Mar 21, 2023
Merged
4 tasks
@AaronFeickert
Copy link
Collaborator

AaronFeickert commented Mar 21, 2023 •
edited
Loading

This looks to be an upstream issue with [email protected]. Freezing at [email protected] is at least a temporary fix.

Opened an upstream issue for this already.

SWvheerden pushed a commit that referenced this issue Mar 22, 2023
@AaronFeickert
test: revert and freeze wasm-pack module (#5262)
e774389 
Description
---
Reverts and freezes `[email protected]` due to an apparent upstream
issue.

Fixes (at least temporarily) [issue
5261](#5261).

Motivation and Context
---
There's an apparent issue with the `wasm-pack` Node.js module at the
0.11.0 version that breaks CI operations (and which [also
affects](tari-project/tari-crypto#174)
`tari-crypto`).

While an [earlier PR](#5258)
disabled this CI, it seems unnecessary and somewhat risky not to have
these tests.

Reverting to the 0.10.3 version is at least a temporary fix.

How Has This Been Tested?
---
With the fix, CI should pass.

What process can a PR reviewer use to test or verify this change?
---
Run the equivalent commands locally, and ensure that CI passes with the
change.


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify
@SWvheerden SWvheerden moved this to Under observation in Tari Esme Testnet Mar 28, 2023
@github-project-automation github-project-automation bot moved this from Under observation to Done in Tari Esme Testnet Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ci Area - Continuous Integration related
Projects
Tari Esme Testnet
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SWvheerden @AaronFeickert