Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

public_addresses can't be set via env var or command line #5260

Closed
Cifko opened this issue Mar 21, 2023 · 0 comments · Fixed by #5303
Closed

public_addresses can't be set via env var or command line #5260

Cifko opened this issue Mar 21, 2023 · 0 comments · Fixed by #5303
Assignees
@Cifko
Labels
A-base_node Area - The Tari base node executable and libraries A-wallet Area - related to the wallet C-enhancement Category - New feature or request

Comments

@Cifko
Copy link
Contributor

Cifko commented Mar 21, 2023

Describe the bug
public_addresses can't be set via env var or command line. There need to be a custom deserializer (similar to peer_seeds) to support Vec. Also in the config.toml are still places with public_address which needs to be changed to public_addresses. It's currently done only in the base node section.

Expected behavior
Probably a comma separated values as in peer_seeds.
@SWvheerden SWvheerden added C-enhancement Category - New feature or request A-base_node Area - The Tari base node executable and libraries A-wallet Area - related to the wallet labels Mar 28, 2023
@SWvheerden SWvheerden moved this to Must Do in Tari Esme Testnet Apr 3, 2023
@Cifko Cifko self-assigned this Apr 11, 2023
@SWvheerden SWvheerden mentioned this issue Apr 12, 2023
Merged
4 tasks
@SWvheerden SWvheerden moved this from Must Do to In Progress in Tari Esme Testnet Apr 13, 2023
SWvheerden pushed a commit that referenced this issue Apr 13, 2023
@Cifko
fix: allow public addresses from command line (#5303)
349ac89 
Description
---
Add `from_str` to `public_addresses` so it can now be set via command
line or envvar.


How Has This Been Tested?
---
There are cargo test and also manually.

What process can a PR reviewer use to test or verify this change?
---
You can set `public_addresses` via commandline.

Fixes: #5260 

Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->
@github-project-automation github-project-automation bot moved this from In Progress to Done in Tari Esme Testnet Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cifko Cifko

Labels
A-base_node Area - The Tari base node executable and libraries A-wallet Area - related to the wallet C-enhancement Category - New feature or request
Projects
Tari Esme Testnet
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow public addresses from command line Cifko/tari
2 participants
@SWvheerden @Cifko