feat!: add claim public key to OutputFeatures #5239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
burn-add-claim-key-to-chain
branch
from
48106ae
to
d4f7121
Compare
stringhandler
pushed a commit
that referenced
this pull request
Mar 15, 2023
### ⚠ BREAKING CHANGES * **wallet:** ensure burn shared keys and hashes match dan layer (5245) * add claim public key to OutputFeatures (5239) * reset esmeralda (5247) ### Features * add claim public key to OutputFeatures ([5239](#5239)) ([3e7d82c](3e7d82c)) * reset esmeralda ([5247](#5247)) ([aa2a3ad](aa2a3ad)) ### Bug Fixes * added transaction revalidation to the wallet startup sequence [5227](#5227) ([5246](#5246)) ([7b4e2d2](7b4e2d2)) * immediately fail to compile on 32-bit systems ([5237](#5237)) ([76aeed7](76aeed7)) * **wallet:** correct change checks in transaction builder ([5235](#5235)) ([768a0cf](768a0cf)) * **wallet:** ensure burn shared keys and hashes match dan layer ([5245](#5245)) ([024ce64](024ce64)) * windows path format in log4rs files ([5234](#5234)) ([acfecfb](acfecfb))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Claim key is required for mask and value recovery of burnt funds on L2.
Unfortunately, since burnt outputs are not part of the utxo set, the wallet does not receive these outputs when recovering. Resolving this is out of scope for this PR.
How Has This Been Tested?
Manually: normal wallet recovery OK. Resync base node OK.
BREAKING CHANGE: Not database or network breaking, but a chain split will occur if a burnt utxo with the claim public key set is broadcast and some nodes have not upgraded.