-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add necessary trait bounds to balanced merkle tree #5232
feat: add necessary trait bounds to balanced merkle tree #5232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The as
casts can overflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fails CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit, otherwise looks good if CI agrees.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Introduces necessary trait bounds to the
BalancedBinaryMerkleProof
struct.Motivation and Context
In order to update the Tari DAN layer repo to make use of BMTs, we need that the current struct
BalancedBinaryMerkleProof
derives certain trait bounds, namely#[derive(Clone, PartialEq, Eq, Deserialize, Serialize)]
.How Has This Been Tested?
Run
cargo build
.