Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wallet] One sided mined at timestamp is incorrect #5167

Closed
SWvheerden opened this issue Feb 7, 2023 · 3 comments · Fixed by #5443
Closed

[Wallet] One sided mined at timestamp is incorrect #5167

SWvheerden opened this issue Feb 7, 2023 · 3 comments · Fixed by #5443
Assignees
@brianp
Labels
A-wallet Area - related to the wallet C-bug Category - fixes a bug, typically associated with an issue. E-good_first_issue Experience Level - Good for newcomers

Comments

@SWvheerden
Copy link
Collaborator

The detected mined at the timestamp should be the block time and not unix epoch.
Screenshot 2023-02-07 at 07 34 58
@SWvheerden SWvheerden added C-bug Category - fixes a bug, typically associated with an issue. A-wallet Area - related to the wallet labels Feb 7, 2023
@stringhandler stringhandler added the E-good_first_issue Experience Level - Good for newcomers label Feb 7, 2023
@SWvheerden SWvheerden changed the title [Wallet] One sided mined at timestamp is correct [Wallet] One sided mined at timestamp is incorrect Feb 13, 2023
@hnidoaht-101
Copy link
Contributor

@stringhandler I'm on Arch Linux. How can I display the icon same as @SWvheerden's screen for Source Address and Destination Address?

@SWvheerden
Copy link
Collaborator Author

@hnidoaht-101 your terminal should support emojis.

@SWvheerden SWvheerden moved this to Must Do in Tari Esme Testnet Mar 28, 2023
@brianp brianp self-assigned this Jun 7, 2023
@brianp brianp mentioned this issue Jun 7, 2023
Merged
4 tasks
@brianp
Copy link
Contributor

brianp commented Jun 7, 2023

Open PR with a fix for this: #5443

SWvheerden pushed a commit that referenced this issue Jun 7, 2023
@brianp
fix: use mined at timestamp in fauxconfirmation (#5443)
f3833c9 
Description
---
We were passing 0 every time when we should have been using the mined at
timestamp.

Motivation and Context
---
Once unconfirmed one sided transactions had been confirmed we were
dropping the proper mined at timestamp.

How Has This Been Tested?
---
Locally with one sided, and one sided stealth transactions between local
wallets on igor.

What process can a PR reviewer use to test or verify this change?
---
Receive a one sided TX, and validate the mined at timestamp is present
once confirmed.

Closes: #5167

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->
@github-project-automation github-project-automation bot moved this from Must Do to Done in Tari Esme Testnet Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianp brianp

Labels
A-wallet Area - related to the wallet C-bug Category - fixes a bug, typically associated with an issue. E-good_first_issue Experience Level - Good for newcomers
Projects
Tari Esme Testnet
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use mined at timestamp in fauxconfirmation brianp/tari
4 participants
@brianp @SWvheerden @stringhandler @hnidoaht-101