Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet FFI has no indication if the base node its connected is healthy or not #5109

Closed
SWvheerden opened this issue Jan 12, 2023 · 0 comments
Closed

Wallet FFI has no indication if the base node its connected is healthy or not #5109

SWvheerden opened this issue Jan 12, 2023 · 0 comments
Assignees
@agubarev
Labels
A-wallet-ffi Area - Related to the wallet FFI lib C-enhancement Category - New feature or request

Comments

@SWvheerden
Copy link
Collaborator

Currently, the wallet FFI has no information about the base node its connected to apart from if its online/offline/connecting.
We should add the base node status to a callback so we can track it for the wallet like we do for the console wallet.
Screenshot 2023-01-12 at 15 40 14
@SWvheerden SWvheerden added C-enhancement Category - New feature or request A-wallet-ffi Area - Related to the wallet FFI lib labels Jan 12, 2023
@SWvheerden SWvheerden moved this to Backlog in Tari Esme Testnet Mar 13, 2023
@SWvheerden SWvheerden moved this from Backlog to Must Do in Tari Esme Testnet Mar 14, 2023
@SWvheerden SWvheerden moved this from Must Do to Selected for development in Tari Esme Testnet Mar 14, 2023
@agubarev agubarev self-assigned this Mar 14, 2023
@agubarev agubarev moved this from Selected for development to In Progress in Tari Esme Testnet Mar 14, 2023
@agubarev agubarev mentioned this issue Mar 17, 2023
Merged
@agubarev agubarev moved this from In Progress to In Review in Tari Esme Testnet Mar 17, 2023
SWvheerden added a commit that referenced this issue Apr 5, 2023
@agubarev @stringhandler
@dependabot @AaronFeickert @leet4tari @SWvheerden
feat: added auxiliary callback to push base node state changes #5109 (#…
b7f7d31 
…5257)

Description
---
Extra function argument to `wallet_create` FFI.

#5109

Motivation and Context
---
Giving mobile app more information about the active base node
connection.

How Has This Been Tested?
---

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: stringhandler <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aaron Feickert <[email protected]>
Co-authored-by: C.Lee Taylor <[email protected]>
Co-authored-by: SW van Heerden <[email protected]>
@SWvheerden SWvheerden mentioned this issue Apr 5, 2023
Merged
SWvheerden added a commit that referenced this issue Apr 5, 2023
@SWvheerden
chore(version): v0.49.0-pre.6 (#5292)
b6a93ee 
##
[0.49.0-pre.6](v0.49.0-pre.5...v0.49.0-pre.6)
(2023-04-05)


### ⚠ BREAKING CHANGES

* move key manager service to key_manager (5284)
* add igor faucet (5281)
* reset dates for networks (5283)

### Features

* add igor faucet
([5281](#5281))
([bfc92fd](bfc92fd))
* added auxiliary callback to push base node state changes
[5109](#5109)
([#5257](#5257))
([b7f7d31](b7f7d31))
* move key manager service to key_manager
([5284](#5284))
([d50ed02](d50ed02))
* reset dates for networks
([5283](#5283))
([d6342a4](d6342a4))


### Bug Fixes

* resize transaction tab windows
([5290](#5290))
([bd95a85](bd95a85)),
closes [#4942](#4942)
[#5289](#5289)
[#12365](https://github.com/tari-project/tari/issues/12365)
@github-project-automation github-project-automation bot moved this from In Review to Done in Tari Esme Testnet Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agubarev agubarev

Labels
A-wallet-ffi Area - Related to the wallet FFI lib C-enhancement Category - New feature or request
Projects
Tari Esme Testnet
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agubarev @SWvheerden