feat: only coinbase output features may have metadata set, and is of limited size; ref #4908 #4960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description Expose iOS libwallet individually - universal / x86-64 / aarch64 Motivation and Context Give developers an option for accessing each iOS architecture individually or as the combined universal library. How Has This Been Tested? Build locally in fork and all libs accessible
stringhandler
approved these changes
Nov 25, 2022
sdbondi
reviewed
Nov 25, 2022
| /// This function will check all stxo to ensure that feature flags where followed | ||
| pub fn check_stxo_rules(&self, height: u64) -> Result<(), TransactionError> { | ||
| pub fn check_output_features(&self, max_coinbase_metadata_size: usize) -> Result<(), TransactionError> { | ||
| for output in self.outputs() { |
There was a problem hiding this comment.
nit(perf): Rather than looping each time in the validation helper, reuse the loop and call this with the output.
sdbondi
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added validation to OutputFeatures which, for now, makes sure that only coinbase output features may have metadata set.
Motivation and Context
Remove Metadata from Output features: metadata is a remnant of the previous DAN implementation. It should be removed from output features
#4908
How Has This Been Tested?
unit tests