Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace consensus with borsh #4920

Merged
merged 17 commits into from
Nov 25, 2022

Conversation

Cifko
Copy link
Contributor

@Cifko Cifko commented Nov 15, 2022

Description

Don't mind for now the Cargo.toml links to my repos. It's just for testing.

Motivation and Context

How Has This Been Tested?

@Cifko Cifko force-pushed the add-borsh-everywhere branch 5 times, most recently from 8d27880 to 3b582a1 Compare November 22, 2022 08:23
@Cifko Cifko force-pushed the add-borsh-everywhere branch 4 times, most recently from c4d7a47 to 0ea20b7 Compare November 23, 2022 08:49
@Cifko Cifko force-pushed the add-borsh-everywhere branch from 0ea20b7 to 10c5273 Compare November 23, 2022 16:25
@stringhandler stringhandler marked this pull request as ready for review November 24, 2022 08:01
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, needs a fair amount of testing.

@Cifko
Copy link
Contributor Author

Cifko commented Nov 24, 2022

Thanks guys. I even cought a bug when I did additional testing.

Copy link
Collaborator

@stringhandler stringhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a bunch of unwraps that need fixing, but going to be easier to see in a new PR. I'll create an issue

@stringhandler stringhandler merged commit e669443 into tari-project:development Nov 25, 2022
@Cifko Cifko deleted the add-borsh-everywhere branch April 18, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants