Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comms): spawn liveness check after address is final #4919

Merged

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Nov 15, 2022

Description

  • Spawns the liveness check after the public address has been finalised

Motivation and Context

Fixes #4915 and fixes an edge case where the old address is used for liveness checks if the user deletes their tor identity before starting the node.

How Has This Been Tested?

Manually

@stringhandler
Copy link
Collaborator

ACK

@stringhandler stringhandler merged commit f558a11 into tari-project:development Nov 15, 2022
@sdbondi sdbondi deleted the fix-no-addr-components-warn branch November 15, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comms liveness check has "Address contained no components." error after creating new base node identity
2 participants