feat: mempool sync wait for node initial sync #4897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CjS77
added
P-acks_required
stringhandler
approved these changes
Nov 7, 2022
CjS77
removed
the
P-reviews_required
|
utACK |
SWvheerden
reviewed
Nov 8, 2022
There was a problem hiding this comment.
While I dont think this fixes the issue completely, it will still run on startup, it will only wait till the node says it is synced. I think this is the better approach.
It might be that the node was off, and there were no new blocks added or not enough to trigger a mempool sync. Coming back on again, the node will ask for new transactions.
If we really wan to stop this from running on startup as per issue #4785 then we need to make the counter for the mempool the max amount on startup.
Base_node sync will then reset that down to 0 when required
|
I'm happy with this approach for now |
|
utACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wait for mempool sync to start after the intial sync is done.
Fixes #4785
How Has This Been Tested?
Manually.