Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mnemonic::to_mnemonic should wrap the seed words in Zeroizing #4861

Closed
sdbondi opened this issue Oct 27, 2022 · 1 comment · Fixed by #4925
Closed

Mnemonic::to_mnemonic should wrap the seed words in Zeroizing #4861

sdbondi opened this issue Oct 27, 2022 · 1 comment · Fixed by #4925
Assignees
@jorgeantonio21
Labels
A-security Area - Security related A-wallet Area - related to the wallet C-bug Category - fixes a bug, typically associated with an issue.
Milestone
Stagenet Freeze

Comments

@sdbondi
Copy link
Member

sdbondi commented Oct 27, 2022 •
edited
Loading

tari/base_layer/key_manager/src/mnemonic.rs

Line 254 in 5b0eb04

fn to_mnemonic(

The TariSeedWords ffi struct may need to be updated, but I don't think this will cause a breaking change as it will not change the underlying representation
@stringhandler stringhandler added C-bug Category - fixes a bug, typically associated with an issue. A-security Area - Security related A-wallet Area - related to the wallet labels Oct 31, 2022
@stringhandler stringhandler added this to the Stagenet Freeze milestone Oct 31, 2022
@brianp
Copy link
Contributor

brianp commented Nov 4, 2022

I'll take a look at this one.

@brianp brianp mentioned this issue Nov 4, 2022
Closed
@stringhandler stringhandler moved this to In Progress in Tari Esme Testnet Nov 9, 2022
@sdbondi sdbondi assigned jorgeantonio21 and unassigned brianp Nov 14, 2022
@jorgeantonio21 jorgeantonio21 mentioned this issue Nov 15, 2022
Merged
stringhandler pushed a commit that referenced this issue Nov 22, 2022
@jorgeantonio21
fix: add hidden types and seed words to key manager (#4925)
0bdb568 
Description
---
We refactor the `key_manager` crate so that hides sensitive data such as mnemonics, encryption and mac keys, etc.

Motivation and Context
---
Tackle issue #4861 and a portion of #4846.

Fixes #4861 

How Has This Been Tested?
---
Add unit tests for `SeedWords`. Also generated need wallet with visible seed words, to the user.
Repository owner moved this from In Progress to Done in Tari Esme Testnet Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorgeantonio21 jorgeantonio21

Labels
A-security Area - Security related A-wallet Area - related to the wallet C-bug Category - fixes a bug, typically associated with an issue.
Projects
Tari Esme Testnet
Archived in project
Milestone
Stagenet Freeze
4 participants
@brianp @sdbondi @stringhandler @jorgeantonio21